Conversation
Summary: These files are shared between projects and were inadvertently modified. Reviewed By: bigfootjon Differential Revision: D98217804
meta-cla
bot
added
the
CLA Signed
bigfootjon
left a comment
bigfootjon
left a comment
There was a problem hiding this comment.
Review automatically exported from Phabricator review in Meta.
bigfootjon
left a comment
bigfootjon
left a comment
There was a problem hiding this comment.
Review automatically exported from Phabricator review in Meta.
bigfootjon
left a comment
bigfootjon
left a comment
There was a problem hiding this comment.
Review automatically exported from Phabricator review in Meta.
bigfootjon
left a comment
bigfootjon
left a comment
There was a problem hiding this comment.
Review automatically exported from Phabricator review in Meta.
There was a problem hiding this comment.
Pull request overview
Restores shared repository metadata files (license and contribution guidelines) to their prior, standardized state after inadvertent modifications, aligning them with Meta Open Source templates.
Changes:
- Reformat MIT LICENSE text to the standard wrapped template and update the copyright line.
- Update CONTRIBUTING.md to the Meta Open Source Projects template language and add an internal PR import workflow note.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| LICENSE | Restores standard MIT license formatting and wording. |
| CONTRIBUTING.md | Updates contribution guidance to Meta OSS template and adds PR import process note. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| ## Pull Requests | ||
| We actively welcome your pull requests. | ||
|
|
||
| Note: pull requests are not imported into the GitHub directory in the usual way. There is an internal Meta repository that is the "source of truth" for the project. The GitHub repository is generated *from* the internal Meta repository. So we don't merge GitHub PRs directly to the GitHub repository -- they must first be imported into internal Meta repository. When Meta employees look at the GitHub PR, there is a special button visible only to them that executes that import. The changes are then automatically reflected from the internal Meta repository back to GitHub. This is why you won't see your PR having being directly merged, but you still see your changes in the repository once it reflects the imported changes. |
There was a problem hiding this comment.
The phrase "having being" is grammatically incorrect here; it should be "having been" (e.g., "you won't see your PR having been directly merged").
| ## Pull Requests | ||
| We actively welcome your pull requests. | ||
|
|
||
| Note: pull requests are not imported into the GitHub directory in the usual way. There is an internal Meta repository that is the "source of truth" for the project. The GitHub repository is generated *from* the internal Meta repository. So we don't merge GitHub PRs directly to the GitHub repository -- they must first be imported into internal Meta repository. When Meta employees look at the GitHub PR, there is a special button visible only to them that executes that import. The changes are then automatically reflected from the internal Meta repository back to GitHub. This is why you won't see your PR having being directly merged, but you still see your changes in the repository once it reflects the imported changes. |
There was a problem hiding this comment.
This note uses inconsistent/unclear terminology ("GitHub directory" vs "GitHub repository" in the same paragraph) and is missing an article in "imported into internal Meta repository". Consider making the terms consistent and updating to "the internal Meta repository" to avoid confusion.
| ## Pull Requests | ||
| We actively welcome your pull requests. | ||
|
|
||
| Note: pull requests are not imported into the GitHub directory in the usual way. There is an internal Meta repository that is the "source of truth" for the project. The GitHub repository is generated *from* the internal Meta repository. So we don't merge GitHub PRs directly to the GitHub repository -- they must first be imported into internal Meta repository. When Meta employees look at the GitHub PR, there is a special button visible only to them that executes that import. The changes are then automatically reflected from the internal Meta repository back to GitHub. This is why you won't see your PR having being directly merged, but you still see your changes in the repository once it reflects the imported changes. |
There was a problem hiding this comment.
Line 9 is a very long single line, while other markdown files in this repo wrap prose to shorter line lengths (e.g., README.md, CODE_OF_CONDUCT.md). Wrapping this paragraph would improve readability and make future diffs/reviews easier.
Summary: These files are shared between projects and were inadvertently modified.
Reviewed By: bigfootjon
Differential Revision: D98217804