tests(linkedpatemplates): added tests for Linked PA Templates API - #80
Open
srajak8 wants to merge 4 commits into
Open
tests(linkedpatemplates): added tests for Linked PA Templates API#80srajak8 wants to merge 4 commits into
srajak8 wants to merge 4 commits into
Conversation
Created the integration test for Linked PA Templates API
This reverts commit dac841e.
added the tests for Linked PA Templates API
srajak8
requested review from
Ramanth (Ramanth) and
Sai Giridhar P (saigiridhar21)
August 13, 2022 13:07
srajak8
requested review from
Akanksha (AkankshaAcharya) and
Vivek Srivatsav Jandhyala (Vivekjvs)
September 2, 2022 10:19
Ramanth (Ramanth)
left a comment
Ramanth (Ramanth)
left a comment
Contributor
There was a problem hiding this comment.
Good job. looking good. left minor comments
| using FactSet.AnalyticsAPI.Engines.Client; | ||
| using FactSet.AnalyticsAPI.Engines.Model; | ||
| using System.Collections.Generic; | ||
| using System.Net; |
Contributor
There was a problem hiding this comment.
remove this duplicate using statement, its already used above
|
|
||
| Assert.IsTrue(response.StatusCode == HttpStatusCode.OK, "Response should be 200 - Success"); | ||
| Assert.IsTrue(response.Data.Data.GetType() == typeof(Dictionary<string, LinkedPATemplateSummary>), "Response should be of Dictionary type."); | ||
| Assert.IsTrue(response.Data.Data[firstTemplate].GetType() == typeof(LinkedPATemplateSummary), "Response should be of LinkedPATemplateSummary type."); |
Contributor
There was a problem hiding this comment.
minor: change the assertion description to "Response dictionary value should be of LinkedPATemplateSummary type"
| const string description = "This is a linked PA template that only returns security level data"; | ||
| List<string> mandatory = new List<string>(2); | ||
| mandatory.Add("accounts"); | ||
| mandatory.Add("benchmarks"); |
Contributor
There was a problem hiding this comment.
Try to declare and initialize the string list in the single line.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
added tests for Linked PA Templates API