perf(query): optimize snapshot decision hot path (<100ms)

[fagemx]

Summary

• add schema v11 index for snapshot hot path: decide_snapshots(village_id, decision_type, created_at DESC)
• optimize query_snapshots with fixed SQL paths, preserve LIMIT/OFFSET, and add hot-path latency warning logs
• rework /api/snapshots caching to per-village recent-100 (TTL 5 min), with in-memory filter/pagination and new regression tests

Closes #319

[fagemx]

Code Review: PR #322

Thanks for the implementation work — I reviewed the full diff against issue #319 scope.

Summary

This PR contains the intended hot-path snapshot optimizations, but it also includes unrelated files and a committed secret, which are blocking issues. The scoped changes in crates/edda-ledger/src/sqlite_store.rs and crates/edda-serve/src/lib.rs look directionally correct and include relevant tests.

Findings

Blockers

• .env:1 includes a real API key (T8STAR_API_KEY=...), which is a credential leak and must not be present in the PR.
• Scope is violated: PR perf(query): optimize snapshot decision hot path (<100ms) #322 includes unrelated files outside perf(query): optimize decision query for hot path (< 100ms) #319 (crates/edda-ask/src/lib.rs, crates/edda-bridge-claude/src/bg_detect.rs, crates/edda-bridge-claude/src/bg_scan.rs, crates/edda-bridge-claude/src/issue_proposal.rs, crates/edda-ledger/Cargo.toml, crates/edda-ledger/src/ledger.rs, opencode.json, plus .env), while the task scope was only crates/edda-ledger/src/sqlite_store.rs and crates/edda-serve/src/lib.rs.

Suggestions

• None.

Four-Point Check

Check	Status	Notes
Scope	❌	PR contains multiple out-of-scope files unrelated to GH-319 implementation contract.
Reality	✅	The introduced APIs and fields in scoped files appear consistent with existing code paths.
Testing	✅	Added/updated tests cover decision_type+offset behavior, cache-window behavior, and perf guard in the hot path.
YAGNI	✅	Scoped changes are targeted to the stated perf/query requirements without obvious over-engineering.

Verdict

Changes Requested

---

Reviewed by edda AI