Handle singleton artifact objects per FAIR spec#497
Open
kasparsd wants to merge 5 commits into
Open
Conversation
Signed-off-by: Kaspars Dambis <hi@kaspars.net>
Signed-off-by: Kaspars Dambis <hi@kaspars.net>
Signed-off-by: Kaspars Dambis <hi@kaspars.net>
Signed-off-by: Kaspars Dambis <hi@kaspars.net>
Signed-off-by: Kaspars Dambis <hi@kaspars.net>
Contributor
kasparsd
commented
May 16, 2026
| // Score artifacts based on match. | ||
| $score_artifact = function ( $artifact ) use ( $langs ) { | ||
| $score = 0; | ||
| $lang = strtolower( $artifact->lang ?? '' ); |
Contributor
Author
There was a problem hiding this comment.
Account for missing lang property which is allowed per spec.
afragen
reviewed
May 16, 2026
| return false; | ||
| } | ||
| $artifact = pick_artifact_by_lang( $release->artifacts->package ); | ||
| $artifact = isset( $release->artifacts->package ) ? pick_artifact_by_lang( $release->artifacts->package ) : null; |
Contributor
There was a problem hiding this comment.
Should this return false for the check below?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #496.
This changeset fixes package handling when a FAIR repository returns
releases[].artifacts.packageas a single object instead of an array.Per the FAIR core spec, the
artifactsmap allows each artifact type value to be either an object or a list of objects. The plugin was normalizing neither shape internally and some consumer paths assumed array access, which caused failures such asCannot use object of type stdClass as arrayduring install/update flows.This patch normalizes release artifact values to arrays at parse time in
ReleaseDocument::from_data(), so downstream code can consume a consistent internal shape regardless of how the repository serialized the artifact. Consumer paths that read package download URLs or inspect package artifacts were updated accordingly, and regression tests were added to cover both valid spec shapes.Spec references
artifactsis a JSON object whose values “MUST be objects or lists of objects”artifacts.packageTesting
Added parser regression tests for: