Skip to content

Remove leftover ( new Updater\Updater( $did ) )->run(); call during DID ajax install #509

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
kasparsd wants to merge 2 commits into
base: release_1.4.1
Choose a base branch
from
+0 −8
Open

Remove leftover ( new Updater\Updater( $did ) )->run(); call during DID ajax install #509

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0bf63f2
Remove leftover
kasparsd May 22, 2026
234bb59
This is now fixed
kasparsd May 27, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions inc/packages/admin/namespace.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -124,8 +124,6 @@ function handle_did_during_ajax( $result, $action, $args ) {
return $result;
}

( new Updater\Updater( $did ) )->run();

Packages\add_package_to_release_cache( $did );
add_filter( 'http_request_args', 'FAIR\\Packages\\maybe_add_accept_header', 20, 2 );

Expand Down
6 changes: 0 additions & 6 deletions tests/phpstan-baseline.neon
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,12 +18,6 @@ parameters:
count: 1
path: ../inc/packages/admin/namespace.php

-
message: '#^Class FAIR\\Updater\\Updater does not have a constructor and must be instantiated without any parameters\.$#'
identifier: new.noConstructor
count: 1
path: ../inc/packages/admin/namespace.php

-
message: '#^Unsafe usage of new static\(\)\.$#'
identifier: new.static
Expand Down
Loading