Skip to content

fix(pireview): sanitize Kimi timeout failures#151

Draft
fall-out-bug wants to merge 1 commit into
mainfrom
codex/pi-review-kimi-timeout
Draft

fix(pireview): sanitize Kimi timeout failures#151
fall-out-bug wants to merge 1 commit into
mainfrom
codex/pi-review-kimi-timeout

Conversation

@fall-out-bug

Copy link
Copy Markdown
Owner

Summary

  • add a Kimi-specific pi-review timeout floor for large review prompts
  • sanitize pi provider errors so persisted review artifacts do not include raw -p prompts
  • keep error unwrapping for timeout/cancel classification and add regression tests

Verification

  • go test ./internal/pireview ./cmd/sdp-pi-review ./internal/executil
  • ./scripts/run_go_quality_gates.sh

Beads: sdplab-tx6h

@github-actions

github-actions Bot commented May 4, 2026

Copy link
Copy Markdown
Contributor

SDP Auto-Attestation

Field Value
Branch codex/pi-review-kimi-timeout
Commit 995b196f
Changed files 2
Tests ✅ pass (5978 passed, 0 failed)
Lint
Scope ✅ no linked workstreams — auto-attested from CI observation
Attestation generation
Coverage ⚠️ 65.20732600732602%
Signed ✅ Sigstore bundle
Beads none
Full attestation report
{
  "all_lint_pass": true,
  "all_tests_pass": true,
  "attestation_id": "ci-auto-151-995b196f",
  "beads_ids": [],
  "branch": "codex/pi-review-kimi-timeout",
  "changed_files": 2,
  "coverage_ok": false,
  "coverage_pct": 65.20732600732602,
  "coverage_threshold": 80,
  "generated_at": "2026-05-04T06:50:40Z",
  "head_commit": "995b196f8ddca46c8cfb9e07cf192761ca3605f2",
  "lint_results": [
    {
      "name": "go-vet",
      "status": "pass"
    },
    {
      "name": "golangci-lint",
      "status": "pass"
    }
  ],
  "out_of_scope": [],
  "scope_compliance": {
    "ok": true,
    "reason": "no linked workstreams — auto-attested from CI observation"
  },
  "test_results": [
    {
      "name": "go-test",
      "status": "pass (5978 passed, 0 failed)"
    }
  ],
  "type": "ci-auto-attestation"
}

Generated by SDP auto-attestation

@fall-out-bug fall-out-bug force-pushed the codex/pi-review-kimi-timeout branch from 995b196 to 9af5726 Compare May 4, 2026 07:14
@github-actions

github-actions Bot commented May 4, 2026

Copy link
Copy Markdown
Contributor

SDP Auto-Attestation

Field Value
Branch codex/pi-review-kimi-timeout
Commit 9af57266
Changed files 2
Tests ✅ pass (5979 passed, 0 failed)
Lint
Scope ✅ no linked workstreams — auto-attested from CI observation
Attestation generation
Coverage ⚠️ 65.20952380952383%
Signed ✅ Sigstore bundle
Beads none
Full attestation report
{
  "all_lint_pass": true,
  "all_tests_pass": true,
  "attestation_id": "ci-auto-151-9af57266",
  "beads_ids": [],
  "branch": "codex/pi-review-kimi-timeout",
  "changed_files": 2,
  "coverage_ok": false,
  "coverage_pct": 65.20952380952383,
  "coverage_threshold": 80,
  "generated_at": "2026-05-04T07:23:15Z",
  "head_commit": "9af5726685cbd7ad4237b62ac2f825af1ee4243c",
  "lint_results": [
    {
      "name": "go-vet",
      "status": "pass"
    },
    {
      "name": "golangci-lint",
      "status": "pass"
    }
  ],
  "out_of_scope": [],
  "scope_compliance": {
    "ok": true,
    "reason": "no linked workstreams — auto-attested from CI observation"
  },
  "test_results": [
    {
      "name": "go-test",
      "status": "pass (5979 passed, 0 failed)"
    }
  ],
  "type": "ci-auto-attestation"
}

Generated by SDP auto-attestation

@fall-out-bug fall-out-bug force-pushed the codex/pi-review-kimi-timeout branch from 9af5726 to 58e5506 Compare May 4, 2026 07:25
@github-actions

github-actions Bot commented May 4, 2026

Copy link
Copy Markdown
Contributor

SDP Auto-Attestation

Field Value
Branch codex/pi-review-kimi-timeout
Commit 58e55064
Changed files 2
Tests ✅ pass (5979 passed, 0 failed)
Lint
Scope ✅ no linked workstreams — auto-attested from CI observation
Attestation generation
Coverage ⚠️ 65.20439560439561%
Signed ✅ Sigstore bundle
Beads none
Full attestation report
{
  "all_lint_pass": true,
  "all_tests_pass": true,
  "attestation_id": "ci-auto-151-58e55064",
  "beads_ids": [],
  "branch": "codex/pi-review-kimi-timeout",
  "changed_files": 2,
  "coverage_ok": false,
  "coverage_pct": 65.20439560439561,
  "coverage_threshold": 80,
  "generated_at": "2026-05-04T07:33:26Z",
  "head_commit": "58e550641a8ae6d2d6008e22fa596065b5cba042",
  "lint_results": [
    {
      "name": "go-vet",
      "status": "pass"
    },
    {
      "name": "golangci-lint",
      "status": "pass"
    }
  ],
  "out_of_scope": [],
  "scope_compliance": {
    "ok": true,
    "reason": "no linked workstreams — auto-attested from CI observation"
  },
  "test_results": [
    {
      "name": "go-test",
      "status": "pass (5979 passed, 0 failed)"
    }
  ],
  "type": "ci-auto-attestation"
}

Generated by SDP auto-attestation

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant