F168: harness skill operating discipline#154
Merged
Merged
Conversation
Contributor
SDP Auto-Attestation
Full attestation report{
"all_lint_pass": true,
"all_tests_pass": true,
"attestation_id": "ci-auto-154-f1e83f17",
"beads_ids": [],
"branch": "codex/harness-skill-synthesis",
"changed_files": 22,
"coverage_ok": false,
"coverage_pct": 65.28571428571429,
"coverage_threshold": 80,
"generated_at": "2026-05-15T09:12:12Z",
"head_commit": "f1e83f17a94292366982a35037bd3e234358e992",
"lint_results": [
{
"name": "go-vet",
"status": "pass"
},
{
"name": "golangci-lint",
"status": "pass"
}
],
"out_of_scope": [],
"scope_compliance": {
"ok": true,
"reason": "no linked workstreams — auto-attested from CI observation"
},
"test_results": [
{
"name": "go-test",
"status": "pass (6129 passed, 0 failed)"
}
],
"type": "ci-auto-attestation"
}
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Review
Local review found and fixed one merge blocker before PR creation:
docs/reference/skill-authoring.mdstill described.agents/skillsas canonical, whilesdp.manifest.yamland.agents/skills/README.mdmakeprompts/skills/<name>/SKILL.mdthe structured source and.agents/skillsthe runtime alias/stub surface. Commitf1e83f17fixes that inconsistency.Verification
go run ./cmd/sdp manifest validate— PASSgo run ./cmd/sdp generate-adapters --check— PASSgo run ./cmd/sdp-protocol-check --lint-skills— PASS, 0 errors, 4 pre-existing warningsgo run ./cmd/sdp-protocol-check --format json— PASS, pre-existing warnings onlygit diff --check— PASSgo run ./cmd/sdp-doc-sync --mode check --strict— FAIL on 56 pre-existing repo-wide docs/backlog issues outside this PR scopeMerge Notes
sdplab-4cxuremainsin_progressuntil merge per repo policy.