feat(impact): whole-project value track credited from full fallow runs#812
Merged
Conversation
Add a separate whole-project Impact track recorded best-effort at the end of a full fallow run, kept apart from the changed-file audit track so the two scopes never share a trend. A full run also credits duplication and whole-repo cleanups fixed outside a changed-file audit. The writer is gated airtight so it records only on a true whole-repo run (check + dupes + health, no scope-narrowing flags, no diff filter, no production mode). A reshaped clone still duplicated under a new fingerprint is not falsely credited resolved. ImpactReport gains optional project_surfacing and project_trend (report schema_version stays 1); human and markdown render an understated whole-project section labelled context, not a to-do.
345e58e to
a5a2a7b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
project_records) recorded best-effort at the end of a fullfallowrun, kept apart from the changed-file audit track so the two scopes never share a trend.Scope::ChangedFiles | WholeProjectattribution: audit credits changed-file fixes; a full run additionally credits duplication and whole-repo cleanups fixed outside a changed-file audit (scope is the union of frontier keys plus this-run finding and clone paths).is_whole_project_run: it records only on a true whole-repo run (check + dupes + health, no--changed-since/--workspace/--changed-workspaces, no active diff filter, no production mode). A reshaped clone that is still duplicated under a new fingerprint is not falsely credited resolved.ImpactReportgains optionalproject_surfacing/project_trend(additive; reportschema_versionstays 1). Human and markdown render an understated whole-project section labelled as whole-repo context, not a to-do, with an "advances only on local full runs, not CI" caveat.Test plan
cargo test --workspace --all-targets: zero failures (pre-push gate green).cargo clippy --workspace --all-targets -- -D warningsclean;cargo fmt --all -- --checkclean.fallowrun accrues the project track;--only dupes,--changed-since,--production, and--diff-stdinall keepproject_recordsempty; the actionable-vs-context labels render correctly in the release binary.