Skip to content

fix(mcp): restore schema descriptions and regenerate schema#822

Open
BartWaardenburg wants to merge 2 commits into
mainfrom
comment-cleanup
Open

fix(mcp): restore schema descriptions and regenerate schema#822
BartWaardenburg wants to merge 2 commits into
mainfrom
comment-cleanup

Conversation

@BartWaardenburg
Copy link
Copy Markdown
Collaborator

Summary:

  • Restore the schema-driving MCP field descriptions that were trimmed too far
  • Regenerate the checked-in root schema artifact

Validation:

  • cargo test -p fallow-mcp converted_field_descriptions_render_in_schema -- --nocapture
  • cargo test --workspace --all-targets
  • git diff --check

@BartWaardenburg BartWaardenburg enabled auto-merge May 31, 2026 17:53
Copy link
Copy Markdown
Contributor

@github-actions github-actions Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Performance Alert ⚠️

Possible performance regression was detected for benchmark 'Fallow Benchmarks'.
Benchmark result of this commit is worse than the previous benchmark result exceeding threshold 1.50.

Benchmark suite Current: 0983cf0 Previous: cab4ab3 Ratio
parse_single_file 64164 ns/iter (± 406) 37282 ns/iter (± 158) 1.72
dupe_detect_2x500_identical 235880 ns/iter (± 12319) 142856 ns/iter (± 1940) 1.65
dupe_detect_2x2000_identical 1072238 ns/iter (± 11644) 635362 ns/iter (± 14709) 1.69
dupe_detect_100x200_mixed 4356454 ns/iter (± 30216) 2550490 ns/iter (± 16010) 1.71
dupe_detect_100x200_mixed_focused 4383980 ns/iter (± 26791) 2576395 ns/iter (± 31927) 1.70
dupe_detect_2x5000_identical 3001302 ns/iter (± 9361) 1733310 ns/iter (± 19658) 1.73

This comment was automatically generated by workflow using github-action-benchmark.

The schema drift check was comparing the committed docs/output-schema.json against the current Rust-derived definitions and found mismatches after the comment cleanup. Regenerate the committed artifact from the schema emitter so the checked-in docs match the source of truth again.\n\nThis stays scoped to the generated schema file. The Rust sources themselves were already passing the drift test locally; the failing branch merge preview needed the committed artifact refreshed to match the current derived shape.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant