Skip to content

fix: clarify TanStack route ignore regex warnings#834

Closed
BartWaardenburg wants to merge 2 commits into
mainfrom
fix/issue-513-tanstack-regex-warning
Closed

fix: clarify TanStack route ignore regex warnings#834
BartWaardenburg wants to merge 2 commits into
mainfrom
fix/issue-513-tanstack-regex-warning

Conversation

@BartWaardenburg
Copy link
Copy Markdown
Collaborator

@BartWaardenburg BartWaardenburg commented Jun 1, 2026

Refs #513

Summary

  • clarify diagnostics for TanStack Router routeFileIgnorePattern values that use JavaScript regex syntax unsupported by fallow
  • keep default behavior as warn and ignore rather than fail config loading
  • add regression coverage from live usage patterns

Verification

  • focused fallow-core routeFileIgnorePattern tests: pass
  • focused generic plugin invalid-regex tests: pass
  • real-project old-vs-new smoke on maximhq/bifrost ui: pass, exits with findings before and after while the warning changes from generic segment-regex wording to routeFileIgnorePattern compatibility wording
  • cargo check --workspace: pass
  • cargo test --workspace --all-targets: pass
  • cargo clippy -p fallow-core --all-targets -- -D warnings: pass
  • cargo clippy -p fallow-cli -p fallow-mcp -- -D warnings: pass
  • cargo test -p fallow-cli -p fallow-mcp: pass
  • cargo fmt --all -- --check: pass
  • git diff --check origin/main...HEAD: pass
  • typos .: pass
  • RUSTDOCFLAGS="-D warnings" cargo doc --workspace --no-deps --document-private-items: pass
  • fallow audit --format json --quiet: exits 0 with warn verdict from duplication attribution outside this reviewed diff

@BartWaardenburg BartWaardenburg force-pushed the fix/issue-513-tanstack-regex-warning branch from 6bf113a to 60d63c8 Compare June 1, 2026 14:14
@BartWaardenburg BartWaardenburg deleted the fix/issue-513-tanstack-regex-warning branch June 1, 2026 15:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant