fix: ignore Svelte script src imports#836
Closed
BartWaardenburg wants to merge 2 commits into
Closed
Conversation
d5d80c8 to
0423cc8
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
<script src>references stay parsed as metadata but no longer emit synthetic imports.<script src>and SFC<style src>behavior stays unchanged.<svelte:head>shape plus Sveltesrcvariants.Issue
Closes #835
Verification
<svelte:head><script src="/some-lib.min.js" async></script></svelte:head>:origin/mainreports/some-lib.min.js, this branch does not.cargo check --workspacecargo test --workspace --all-targetscargo clippy --workspace --all-targets -- -D warningscargo fmt --all -- --checkcargo doc --workspace --no-deps --document-private-itemstypos .git diff --checkfallow audit --format json --quiet(warn verdict from generated-file duplication unrelated to this Svelte change)