feat: resolve Pinia store auto-imports#837
Closed
BartWaardenburg wants to merge 2 commits into
Closed
Conversation
943e535 to
0458fe9
Compare
Collaborator
Author
|
Landed directly on main in 216094f. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
@pinia/nuxt.stores/andapp/stores/value exports nameduse<Name>Storeas convention auto-import providers.storesDirsoutside the default detector, with tests documenting that boundary.Issue
Closes #740
Verification
cargo fmt --all -- --checkcargo check --workspacecargo clippy --workspace --all-targets -- -D warningscargo test --workspace --all-targetsRUSTDOCFLAGS="-D warnings" cargo doc --workspace --no-deps --document-private-itemstarget/debug/fallow audit --format json --quietorigin/mainreportsstores/user.ts; this branch keepsstores/user.tsanduseUserStorealive while still reporting the unused helper export.BabluMia/Nuxt-Pinia: no crash and no regression on direct store reporting. This repo imports its stores explicitly, so it is not used as the behavioral delta proof.zod,preact, andviteJSON output parsed with no NaN or Infinity values.