fix(plugins): credit oxlint config packages referenced via the extends array#851
Closed
BartWaardenburg wants to merge 2 commits into
Closed
fix(plugins): credit oxlint config packages referenced via the extends array#851BartWaardenburg wants to merge 2 commits into
BartWaardenburg wants to merge 2 commits into
Conversation
e056928 to
5de58c8
Compare
Collaborator
Author
|
Landed on main via maintainer direct-to-main flow, squashed into 27e4c3f. The linked issue is fixed on main; closing this PR as redundant. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In
crates/core/src/plugins/oxlint.rs,OxlintPlugin::resolve_confignow parses the top-level"extends"array from oxlint config files. Package-style entries (e.g.@nkzw/oxlint-config) are credited asreferenced_dependencies; relative/absolute path entries (e.g../local.json) are recorded assetup_files. The logic reuses the existingis_local_specifier/is_package_specifier/resolve_config_relative_pathhelpers already used forjsPlugins, keeping the change minimal. A regression test covering both cases was added and passes.Review
Verdict: SHIP
.claude/rules/plugins.mdOxlint entry documentsjsPluginsbut not the new extends parsing; a one-line doc update would keep detection docs current (informational, may lag code per project convention).git commit -Sand a valid author before push.Closes #846