refactor(daemon): retire dead BEAM-mesh Reporter + in-process Coordinator (E4)#214
Merged
Merged
Conversation
…ator (E4) Per the Phase E E4 decision (retire). Sykli.Reporter (the worker→coordinator occurrence forwarder) was started by no supervisor; its consumer, the in-process Sykli.Coordinator GenServer (daemon coordinator/full mode), therefore had no producer and no query consumers. Removed both modules, the daemon child wiring, and the coordinator test. Team Mode coordination uses the self-hosted HTTP coordinator (Sykli.Coordinator.Client → POST /v1/...), which is unaffected. Daemon :coordinator/:full roles still differ in execution eligibility; they just no longer start the dead GenServer. Verification: mix format/credo/test (1746, 0 failures), escript.build, black-box 0 failed (GH-4 expected-red). Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes the Phase E E4 item with the retire decision.
Sykli.Reporter(BEAM-mesh worker→coordinator occurrence forwarder) was started by no supervisor, and its consumer — the in-processSykli.CoordinatorGenServer (started in daemon coordinator/full mode) — therefore had no producer and no query consumers (verified: nothing outside Reporter/daemon/its own test referenced it). Both were an isolated, dead subsystem.Removed
core/lib/sykli/reporter.excore/lib/sykli/coordinator.ex(the in-process GenServer — notCoordinator.Client, the HTTP transport, which stays)core/test/sykli/coordinator_test.exsSykli.Coordinatorfrom daemon:coordinator/:fullchildrenTeam Mode coordination uses the self-hosted HTTP coordinator (
Sykli.Coordinator.Client), unaffected. Daemon role distinctions (execute vs coordinate) live in placement logic, not this wiring.Note: this supersedes Phase E's E2 fix (
connected_nodes/0Node.ping→Node.list) — that function is removed with the module. E2 was correct given the pre-retire decision; retiring is the agreed end state.Verification
mix format/mix credo(clean) /mix test(1746, 0 failures) /mix escript.build; black-box 0 failed (GH-4 expected-red, deferred to Phase C).🤖 Generated with Claude Code