Skip to content

feat: add opengraph properties to preview_url spec#49

Open
cperrin88 wants to merge 1 commit into
famedly:mainfrom
cperrin88:feature/cperrin88/add_og_data_to_preview_url
Open

feat: add opengraph properties to preview_url spec#49
cperrin88 wants to merge 1 commit into
famedly:mainfrom
cperrin88:feature/cperrin88/add_og_data_to_preview_url

Conversation

@cperrin88

Copy link
Copy Markdown

The Matrix spec doesn't specify enough opengraph properties to make the preview_url endpoint useful. This patch adds some usefule properties.

@cperrin88 cperrin88 requested a review from a team as a code owner September 23, 2024 14:22
@CLAassistant

CLAassistant commented Sep 23, 2024

Copy link
Copy Markdown

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@lukaslihotzki-f

Copy link
Copy Markdown

This seems to be generally useful, so please open a PR upstream first: https://github.com/matrix-org/matrix-spec

@cperrin88

Copy link
Copy Markdown
Author

They went with a different route in the spec. They just linked to the OpenGraph Spec: matrix-org/matrix-spec#1753

Would you consider this PR again now?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants