feat(dart): Add Dart devshell and CI workflow#33
Open
nikzen wants to merge 2 commits into
Open
Conversation
Add a `dart` devshell that ships the pinned SDK from `./sdk.nix`, so local development and CI share identical toolchain binaries. Flutter is preferred where available (it bundles a full Dart SDK); aarch64-linux falls back to the standalone Dart SDK. Inherits the standard `prek` commands like the other language shells. Co-authored-by: Cursor <cursoragent@cursor.com>
Generate a `dart-ci` GitHub Actions workflow whenever `famedly.standards.dart.projects` is non-empty, translating the experimental Dart CI into main's `github-actions-nix` + filegen idiom. Each configured project gets a lint job (import sorting, dependency validation, dart_code_linter, translations cleaner, commented-out-code check) plus opt-in test and coverage (Codecov) jobs. Jobs reuse the pinned SDK packages so CI and the devshell share identical toolchains. Adds the `actions/cache` and `codecov/codecov-action` pins to the action allowlist. Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Stacked on #31 (Dart/Flutter SDK packages). Wires the pinned SDKs into a development shell and a generated CI workflow, integrating with main's existing
github-actions-nix+filegen+prekinfrastructure.nix/dart/devshell.nix): adds adartdevshell that ships the pinned SDK from./sdk.nix, so local development and CI share identical toolchain binaries. Flutter is preferred where available (it bundles a full Dart SDK); aarch64-linux falls back to the standalone Dart SDK. Inherits the standardprekcommands.nix/dart/workflow.nix): generatesdart-ci.ymlwheneverfamedly.standards.dart.projectsis non-empty. Each project gets a lint job (import sorting, dependency validation,dart_code_linter, translations cleaner, commented-out-code check) plus opt-in test and coverage (Codecov) jobs. Theprojectssubmodule is extended with the corresponding options; the attribute key is the project's relative path.actions/cache(v4.3.0) andcodecov/codecov-action(v5.5.5).Test plan
nixfmt-rfc-style --checkandprek run --filespass for all changed filesdartdevshell and SDK packages presentdart-ci.ymlis generated for this repo (no Dart projects configured)dart-ci.ymlverified (correct SHAs, triggers, permissions, lint/test/coverage jobs)working-directory)Made with Cursor