Conversation
|
These are here: https://github.com/farsounder/farsounder-cpp-client/actions/runs/21883409612 Can't believe it actually built first try - testing them each completely standalone to see if it's true. |
|
These worked completely standalone 🎉 - linking just a basic_client.cpp against them on windows and ubuntu. Probably going to make that example available too as it's a lot simpler than what's in this repo. |
There was a problem hiding this comment.
Pull request overview
Adds a GitHub Actions workflow to automatically build, test, install (stage), and upload SDK package artifacts for Windows and Ubuntu, aligning CI with the project’s CMake install/export packaging approach.
Changes:
- Added a CI workflow to build + run tests on Windows and Ubuntu and upload staged install artifacts.
- Added validation checks to ensure the staged install contains expected binaries/headers/CMake package files/license.
- Removed the completed TODO entry about adding GitHub Actions build/test from the README.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| README.md | Removes the now-completed TODO item for GitHub Actions build/test. |
| .github/workflows/build-test-package.yml | New workflow to configure/build/test/install/validate and upload packaged artifacts for Windows + Ubuntu. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Add action to build, test, spit out the installable packages (dll/shared lib and headers) on windows and ubuntu