Improve wording #323
Closed
Improve wording #323
+14
−10
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alugowski
reviewed
Sep 19, 2025
alugowski
approved these changes
Oct 21, 2025
Member
|
This changes too many lines needlessly. I will revise the readme manually. |
thbeu
commented
Jan 19, 2026
| return EXIT_SUCCESS; | ||
| } | ||
| std::cerr << "failed to parse " << result << std::endl; | ||
| std::cerr << "parsing failure\n"; |
Author
There was a problem hiding this comment.
@lemire I would not say needlessly. You unfortunately missed this change where result variable was accessed which could give erroneous behavior. This change introduces consistency with the other code examples.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.