Minor fixes#41
Merged
Merged
Conversation
Member
lemire
commented
Jun 3, 2025
lemire
commented
- Some of the code did not seem quite portable. Some non-constexpr strings were passed to functions expecting constexpr strings. Though this might be fine in some contexts, it can also cause errors.
- I have worked a bit on speeding up the initial build by replacing some (though not all) git dependencies by zip ball dependencies. It is often faster to grab a zip file than to go through git. This is especially true with the swift tree which is huge.
Collaborator
|
Excellent, let's merge ! |
Member
Author
|
@jaja360 Thanks for merging. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.