fix: Allow --aot-cache and --debug-intermediate-files flags to be specified with equals#1403
Open
fix: Allow --aot-cache and --debug-intermediate-files flags to be specified with equals#1403
--aot-cache and --debug-intermediate-files flags to be specified with equals#1403Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The CLI parses command line flags by iterating each token.
Flags that take values (e.g.,
--engine-wasm) can be processed with or without an equals sign after the flag namee.g., the following are equivalent:
The logic to check for the "equals" version was missing from
--aot-cacheand--debug-intermediate-files.This PR adds those.
Additionally, the error message when
--debug-intermediate-fileswas missing a value was mislabeled. This PR fixes that.