Skip to content

fix: Allow --aot-cache and --debug-intermediate-files flags to be specified with equals#1403

Open
harmony7 wants to merge 1 commit intomainfrom
kats/fix-parse-inputs
Open

fix: Allow --aot-cache and --debug-intermediate-files flags to be specified with equals#1403
harmony7 wants to merge 1 commit intomainfrom
kats/fix-parse-inputs

Conversation

@harmony7
Copy link
Copy Markdown
Member

@harmony7 harmony7 commented Apr 1, 2026

The CLI parses command line flags by iterating each token.

Flags that take values (e.g., --engine-wasm) can be processed with or without an equals sign after the flag name

e.g., the following are equivalent:

js-compute-runtime --engine-wasm=foo.wasm input.js output.wasm
js-compute-runtime --engine-wasm foo.wasm input.js output.wasm

The logic to check for the "equals" version was missing from --aot-cache and --debug-intermediate-files.
This PR adds those.

Additionally, the error message when --debug-intermediate-files was missing a value was mislabeled. This PR fixes that.

@harmony7 harmony7 requested a review from TartanLlama April 1, 2026 07:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant