This repository was archived by the owner on Dec 13, 2023. It is now read-only.
Conversation
added 2 commits
June 14, 2019 11:47
Currently the `Address` defined in the TOML conffig is used for both `Address` and `IPV4` fields in the API. Validation on the `IPV4` value prevents this from being a hostname. However, the `Address` can be either hostname, IPv4 or IPv6 address and is automatically parsed by the API.
- Refactored AddLoggingCondition, broke out creation of web and WAF logs. - Logging and conditons now only created if config file has valid log configs. - Creation off logging endpoints can now be explicitly disabled through CLI arg `--no-logs` - Refactored CLI output to past-tense.
Member
|
@ejthurgo @marklkelly Is this still relevant or superseded by #96? |
Author
|
I think some aspects of this were taken into 96. @marklkelly would be the authority on this. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
--no-logsResolves issue: #70
Resolves issue: #71
Resolves issue: #91