Fix listen button interactions#4512
Closed
ComputelessComputer wants to merge 2 commits intofix-hide-empty-transcript-and-summary-tabsfrom
Closed
Fix listen button interactions#4512ComputelessComputer wants to merge 2 commits intofix-hide-empty-transcript-and-summary-tabsfrom
ComputelessComputer wants to merge 2 commits intofix-hide-empty-transcript-and-summary-tabsfrom
Conversation
Add select-none class to prevent unwanted text selection when interacting with floating action buttons, improving user experience during button clicks and drags.
Replace PopoverTrigger with PopoverAnchor and add context menu handler to enable right-click opening of the options menu. The change maintains existing click behavior while providing additional accessibility through right-click interaction.
ComputelessComputer
force-pushed
the
fix-hide-empty-transcript-and-summary-tabs
branch
from
ab584a3 to
5002f50
Compare
ComputelessComputer
force-pushed
the
c-branch-7
branch
from
58be8c3 to
21170bd
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix the floating listen control so primary and secondary actions behave correctly.
Verification
pnpm exec dprint fmt apps/desktop/src/session/components/floating/options-menu.tsx apps/desktop/src/session/components/floating/shared.tsxpnpm -F @hypr/desktop typecheckThis is part 2 of 2 in a stack made with GitButler: