Apply cargo clippy fixes and format with cargo fmt#4575
Open
devin-ai-integration[bot] wants to merge 5 commits intomainfrom
Open
Apply cargo clippy fixes and format with cargo fmt#4575devin-ai-integration[bot] wants to merge 5 commits intomainfrom
devin-ai-integration[bot] wants to merge 5 commits intomainfrom
Conversation
Co-Authored-By: bot_apk <apk@cognition.ai>
Contributor
Author
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
✅ Deploy Preview for hyprnote-storybook canceled.
|
✅ Deploy Preview for hyprnote canceled.
|
Co-Authored-By: bot_apk <apk@cognition.ai>
Co-Authored-By: bot_apk <apk@cognition.ai>
…_sqlite.rs Co-Authored-By: bot_apk <apk@cognition.ai>
Co-Authored-By: bot_apk <apk@cognition.ai>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Ran
cargo clippy --fixfollowed bycargo fmtanddprint fmtacross the workspace. The effective changes span 3 files:Clippy lint fixes (semantic changes):
if/if letblocks intoif letchain using&&syntax (cactus/batch.rs)partition_tokens_by_word_finality(soniox/live.rs)Workspace config (
Cargo.toml): Excludedplugins/apple-contactandplugins/pdffrom workspace members (these directories have noCargo.toml, onlynode_modules/, which blockscargofrom resolving the workspace).Review & Testing Checklist for Human
if letchain syntax compatibility — The collapsedif let ... && ...syntax incactus/batch.rsrequires Rust 1.87.0+. Confirm the project's toolchain/MSRV supports this.plugins/apple-contactandplugins/pdfare excluded because they lack aCargo.toml. Confirm these shouldn't have aCargo.tomladded instead.Notes
fmtCI check passes. The only failing check (desktop_ci linux-x86_64) is a pre-existingcactus-sysARM architecture build error on x86, unrelated to this PR.