fix: prevent shared Option causing race by switching to value instead of pointer#21
Merged
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #21 +/- ##
==========================================
- Coverage 99.74% 99.74% -0.01%
==========================================
Files 15 15
Lines 3579 3576 -3
==========================================
- Hits 3570 3567 -3
Misses 5 5
Partials 4 4
🚀 New features to boost your workflow:
|
c4milo
pushed a commit
to c4milo/qjs
that referenced
this pull request
Nov 19, 2025
…er_runtime fix: prevent shared Option causing race by switching to value instead of pointer
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Poolcreation used*Option, causing all runtimes to share the sameOption.ProxyFunction.ProxyFunctionis created using the runtime-specific registry:As a result:
ProxyFunction.proxyRegistry.Fix:
Replace
*OptionwithOption(value type) to ensure each runtime gets its ownProxyFunctionbound to the correct registry.