Add dynamic/custom hostname during installation#454
Open
dsbilling wants to merge 7 commits intofatihak:mainfrom
Open
Add dynamic/custom hostname during installation#454dsbilling wants to merge 7 commits intofatihak:mainfrom
dsbilling wants to merge 7 commits intofatihak:mainfrom
Conversation
Introduced functions to retrieve the MAC address and set the system hostname to the app name plus the last 4 characters of the MAC address. This ensures unique hostnames for each device during installation.
This reverts commit 15697b7.
Introduces the -H option to allow users to specify a custom hostname during installation. If not provided, the script continues to auto-generate the hostname based on the MAC address. Updates usage instructions and argument parsing accordingly.
Enhanced the error handling in install.sh to provide specific usage instructions when required arguments for -W and -H options are missing, improving user guidance during installation.
Contributor
Author
|
@fatihak Sorry for delayed response, here is the rework 👍🏻 |
Updated install.sh and README.md to allow users to skip setting the hostname by passing -H "" or -H none. Improved argument parsing and documentation to clarify the new behavior and provide usage examples.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reworked from #435