Open
Conversation
e88a3ab to
04741c1
Compare
Author
|
For info: I force pushed this, to sync it with the requirements bump from 13th Feb 26 since I changed those files as well and removed one merge commit I accindently included. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This introduces dynamic font loading to the InkyPi core. For full description see: /docs/fonts.md.
It maintains full backward compatibility still using the hardcoded fonts and they keep prioity even when dynamic loading finds them somwhere else with the same name.
It makes all fonts available for everyone and includes fonts that come with installed plugins.
It makes it easy for plugins to bring their own fonts without needing to modify core files.
(without the need to modify plugin mechanism, it just scans all plugins for font dirs and includes them)
It scans for fonts the first time they are requested and keeps them available for rendering (base plugin) and settings.
The internal API remains unchanged, so nothing else needs to be updated.
It uses fonttools to extract meta data.
It comes with extensive fall back and overwrite logic to be robust and flexible.
It's easy to use: just drop fonts in the fonts dir or your plugin's fonts dir, restart the service and be done - no further code changes required.
All in all it makes developing plugins easier and InkyPi more 3rd-party-plugin-friendly.