Open
Conversation
There was a problem hiding this comment.
Pull request overview
This PR addresses a few small correctness/quality issues across image handling and plugin execution, including restoring a missing completion log and making network calls more robust.
Changes:
- Clean up
resize_image()crop setup by removing a duplicatedesired_ratioassignment and normalizing tuple spacing. - Fix “lost” completion logging in the Image Folder plugin by moving the completion log before the successful return (and removing unreachable code).
- Add explicit request timeouts to Immich album discovery and asset pagination calls.
- Force unbuffered Python output via
PYTHONUNBUFFERED=1in the launcher script.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/utils/image_utils.py | Removes duplicate ratio computation and normalizes initialization formatting in resize_image(). |
| src/plugins/image_folder/image_folder.py | Moves completion log into the success path and removes unreachable code after raise. |
| src/plugins/image_album/image_album.py | Adds timeout=30 to Immich API GET/POST requests for better reliability. |
| install/inkypi | Exports PYTHONUNBUFFERED=1 to ensure unbuffered runtime output. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.