Skip to content

Comments

Fix minor issues & lost prints#608

Open
boidolr wants to merge 4 commits intofatihak:mainfrom
boidolr:fix/merge-issues
Open

Fix minor issues & lost prints#608
boidolr wants to merge 4 commits intofatihak:mainfrom
boidolr:fix/merge-issues

Conversation

@boidolr
Copy link
Contributor

@boidolr boidolr commented Feb 21, 2026

No description provided.

Copilot AI review requested due to automatic review settings February 21, 2026 15:59
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR addresses a few small correctness/quality issues across image handling and plugin execution, including restoring a missing completion log and making network calls more robust.

Changes:

  • Clean up resize_image() crop setup by removing a duplicate desired_ratio assignment and normalizing tuple spacing.
  • Fix “lost” completion logging in the Image Folder plugin by moving the completion log before the successful return (and removing unreachable code).
  • Add explicit request timeouts to Immich album discovery and asset pagination calls.
  • Force unbuffered Python output via PYTHONUNBUFFERED=1 in the launcher script.

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.

File Description
src/utils/image_utils.py Removes duplicate ratio computation and normalizes initialization formatting in resize_image().
src/plugins/image_folder/image_folder.py Moves completion log into the success path and removes unreachable code after raise.
src/plugins/image_album/image_album.py Adds timeout=30 to Immich API GET/POST requests for better reliability.
install/inkypi Exports PYTHONUNBUFFERED=1 to ensure unbuffered runtime output.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant