fix(dumbridge): pin @effect/platform-node-shared to stop the install peer warning - #80
Conversation
|
bugbot run |
|
@codex review |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (3)
📝 WalkthroughWalkthroughAdds ChangesEffect platform dependency alignment
Estimated code review effort: 1 (Trivial) | ~5 minutes 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Warning There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure. 🔧 Biome (2.5.3).fallowrc.jsonFile contains syntax errors that prevent linting: Line 13: Expected a property but instead found '// CRAP scores are static estimates here (bun test emits no Istanbul'.; Line 16: End of file expected; Line 16: End of file expected; Line 16: End of file expected; Line 17: End of file expected; Line 18: End of file expected; Line 18: End of file expected; Line 19: Expected a property but instead found '// Inherited findings stay visible in reports; only findings introduced'.; Line 18: End of file expected; Line 19: End of file expected; Line 21: End of file expected; Line 21: End of file expected; Line 21: End of file expected; Line 22: End of file expected; Line 27: End of file expected; Line 27: End of file expected; Line 27: End of file expected; Line 27: End of file expected; Line 28: End of file expected; Line 28: End of file expected; Line 30: Expected a property but instead found '// dist/cli.js externalizes Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
✅ Bugbot reviewed your changes and found no new issues!
Comment @cursor review or bugbot run to trigger another review on this PR
Reviewed by Cursor Bugbot for commit 006f92b. Configure here.
|
Codex Review: Didn't find any major issues. Another round soon, please! Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
Summary
Fresh installs of
dumbridge@1.0.0printwarn: incorrect peer dependency "effect@4.0.0-beta.98"(bun; npm silently installs a secondeffectcopy).@effect/platform-bun@4.0.0-beta.98depends on@effect/platform-node-shared@^4.0.0-beta.98. Under prerelease semver that caret range also matches the newer4.0.0-beta.99, so fresh installs resolve node-shared at beta.99 — whose peer range iseffect@^4.0.0-beta.99, which our exact-pinnedeffect@4.0.0-beta.98fails.@effect/platform-node-shared@4.0.0-beta.98as a direct dependency ofdumbridge. Both bun and npm then dedupe the whole@effectgraph onto beta.98 and oneeffectinstance; verified with clean tarball installs under both package managers (warning gone, singleeffectinnpm ls).@number0/irohalias and everything else unchanged;.fallowrc.jsongains anignoreDependenciesentry since nothing imports the pin directly.Test plan
bun add/npm iof the packed tarball in clean temp dirs: no peer warning, node-shared resolves to beta.98, single dedupedeffectbunx --no-install dumbridge --version/--helpfrom the tarball installbun run verifygreenfallow audit --base origin/mainexits 0Note
Low Risk
Dependency-resolution and tooling config only; no application or runtime logic changes.
Overview
Pins
@effect/platform-node-shared@4.0.0-beta.98as a direct dependency ofdumbridgeso fresh installs no longer float that transitive package to a newer beta (via@effect/platform-bun’s caret range) whoseeffectpeer no longer matches the app’s exacteffect@4.0.0-beta.98. The goal is one dedupedeffectinstance and no incorrect-peer warnings under bun/npm..fallowrc.jsonaddsignoreDependenciesfor that package because nothing imports it directly—it exists only to steer resolution. A changeset records adumbridgepatch;bun.lockreflects the new dependency (and workspace version entries in the lock snapshot).Reviewed by Cursor Bugbot for commit 006f92b. Bugbot is set up for automated code reviews on this repo. Configure here.
Summary by CodeRabbit