fix: emit valueChanged signals for List and Optional widgets#103
Draft
hthienloc wants to merge 1 commit into
Draft
fix: emit valueChanged signals for List and Optional widgets#103hthienloc wants to merge 1 commit into
hthienloc wants to merge 1 commit into
Conversation
- Connect model mutation signals (rowsInserted, rowsRemoved, dataChanged, rowsMoved) to OptionWidget::valueChanged() in ListOptionWidget. - Connect checkbox state and sub-widget changes to OptionWidget::valueChanged() in OptionalOptionWidget. Fixes fcitx#100
Author
|
I need to test this carefully. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR addresses issue #100 by ensuring that
ListOptionWidgetandOptionalOptionWidgetcorrectly notify the parent configuration dialog when their values change.Previously, these widgets modified their internal state/model but failed to emit the
OptionWidget::valueChanged()signal. This caused the "Apply" and "OK" buttons in the main configuration window to remain disabled, effectively preventing users from saving changes to these fields unless another unrelated setting was also modified.Changes
rowsInserted,rowsRemoved,dataChanged, androwsMovedsignals from the internal model tovalueChanged().valueChangedsignal to the parent'svalueChanged().Evidence
In
src/lib/configwidgetslib/optionwidget.cpp, all other basic widgets (Integer, String, Boolean, Enum) already follow this pattern to enable change detection:This PR brings
ListOptionWidgetandOptionalOptionWidgetinto consistency with the rest of the library.Fixes #100