Skip to content

kcm_fcitx5.json: add a bugreport URL#105

Merged
wengxt merged 3 commits into
fcitx:masterfrom
Managor:bugreport
Jun 25, 2026
Merged

kcm_fcitx5.json: add a bugreport URL#105
wengxt merged 3 commits into
fcitx:masterfrom
Managor:bugreport

Conversation

@Managor

@Managor Managor commented Jun 19, 2026

Copy link
Copy Markdown
Contributor

This will show up here and it will allow directing users directly to the correct issue tracker
image

Summary by CodeRabbit

  • Bug Fixes
    • Added a bug report URL in the configuration metadata to make it easier to submit and track issues.

@coderabbitai

coderabbitai Bot commented Jun 19, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: 3ce305a0-413e-4376-a42f-e3d070bf8544

📥 Commits

Reviewing files that changed from the base of the PR and between 72bc9ad and 2898335.

📒 Files selected for processing (1)
  • src/kcm/kcm_fcitx5.json
✅ Files skipped from review due to trivial changes (1)
  • src/kcm/kcm_fcitx5.json

📝 Walkthrough

Walkthrough

A single BugReportUrl field pointing to the fcitx5-configtool GitHub issues page is added to src/kcm/kcm_fcitx5.json. No other keys, values, or files are modified.

Changes

KCM Metadata Update

Layer / File(s) Summary
Add BugReportUrl to KCM descriptor
src/kcm/kcm_fcitx5.json
Adds BugReportUrl entry to the KCM module JSON metadata, pointing to the project's GitHub issues page.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Poem

🐇 One tiny link in a JSON stream,
To where bug reports hop and teem.
A little URL, neat and new,
For curious paws to follow through.

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly describes the main change: adding a bugreport URL to kcm_fcitx5.json.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands.

@wengxt

wengxt commented Jun 24, 2026

Copy link
Copy Markdown
Member

seems nice, but also it seems that their implement has a bug that will blindly append &version

https://github.com/KDE/systemsettings/blob/f6c4cc26a60e65eedaf02e582e416fa227b27c4c/app/SettingsBase.cpp#L157

Which will break this?...

@Managor

Managor commented Jun 24, 2026

Copy link
Copy Markdown
Contributor Author

Thanks. I went ahead and made a patch for it.

https://invent.kde.org/plasma/systemsettings/-/merge_requests/412

@wengxt

wengxt commented Jun 24, 2026

Copy link
Copy Markdown
Member

At the same time, can you workaround it with ?dummy=1 so this can work with current implantation

also report to fcitx5 instead of fcitx5-configtool seems to be a better idea.

@Managor

Managor commented Jun 24, 2026

Copy link
Copy Markdown
Contributor Author

also report to fcitx5 instead of fcitx5-configtool seems to be a better idea.

I disgree because the bug report pertains to the kcm itself, not fcitx5 as a whole

@wengxt

wengxt commented Jun 24, 2026

Copy link
Copy Markdown
Member

from user perspective user might not think the same way, if they want to report bug to fcitx itself.

Also issue transfer on github between repo is easy. I'd rather all bugs are reported to fcitx5 repo and moved later after triage.

@Managor

Managor commented Jun 24, 2026

Copy link
Copy Markdown
Contributor Author

Fair enough.

@wengxt wengxt merged commit 21a30d5 into fcitx:master Jun 25, 2026
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants