read surrounding text#376
Merged
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR adds support for reading and forwarding the client’s surrounding text/selection info from the macOS InputMethodKit layer into the fcitx input context, so fcitx can make better context-dependent decisions (e.g., around selection/caret behavior).
Changes:
- Collect surrounding text + cursor/anchor in Swift and pass them into
process_key(...). - Extend the C++ frontend key event path to accept surrounding text and update
InputContextsurrounding text state. - Enable
CapabilityFlag::SurroundingTextwhen not in password mode.
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
src/controller.swift |
Captures surrounding text/cursor/anchor per key event and forwards them to process_key. |
macosfrontend/macosfrontend.swift |
Implements getSurroundingText(...) using IMKTextInput APIs. |
macosfrontend/macosfrontend.h |
Extends keyEvent(...) signature; adds setSurroundingText(...) and cached last values. |
macosfrontend/macosfrontend.cpp |
Plumbs surrounding text into keyEvent(...), stores it on the input context, and sets SurroundingText capability when appropriate. |
macosfrontend/macosfrontend-public.h |
Updates the exported process_key(...) signature to include surrounding text + cursor/anchor. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
arm64 comparisonNo difference. x86_64 comparisonNo difference. |
6519317 to
210bcf0
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.