Add four translitterations#4
Open
xaltsc wants to merge 4 commits into
Open
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: ⛔ Files ignored due to path filters (12)
📒 Files selected for processing (3)
🚧 Files skipped from review as they are similar to previous changes (2)
📝 WalkthroughWalkthroughAdds four new table-based input methods—Etruscan, Tifinagh, Phoenician, and Hebrew—each with a ChangesNew Table Input Methods
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@tables/he/hebrew.txt`:
- Line 2: The Hebrew key table definition is missing uppercase C in the KeyCode
string, which prevents the existing C-to-ץ mapping from being reachable. Update
the KeyCode declaration in the hebrew table so it includes C alongside the other
allowed keys, and ensure the corresponding mapping symbol remains consistent
with the entry defined for that key.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro Plus
Run ID: 02a0ceb5-91ff-4ede-a279-6b7c02777ca6
⛔ Files ignored due to path filters (48)
icons/16x16/apps/fcitx_etruscan.pngis excluded by!**/*.pngicons/16x16/apps/fcitx_hebrew.pngis excluded by!**/*.pngicons/16x16/apps/fcitx_phoenician.pngis excluded by!**/*.pngicons/16x16/apps/fcitx_tifinagh.pngis excluded by!**/*.pngicons/16x16/apps/org.fcitx.Fcitx5.fcitx_etruscan.pngis excluded by!**/*.pngicons/16x16/apps/org.fcitx.Fcitx5.fcitx_hebrew.pngis excluded by!**/*.pngicons/16x16/apps/org.fcitx.Fcitx5.fcitx_phoenician.pngis excluded by!**/*.pngicons/16x16/apps/org.fcitx.Fcitx5.fcitx_tifinagh.pngis excluded by!**/*.pngicons/22x22/apps/fcitx_etruscan.pngis excluded by!**/*.pngicons/22x22/apps/fcitx_hebrew.pngis excluded by!**/*.pngicons/22x22/apps/fcitx_phoenician.pngis excluded by!**/*.pngicons/22x22/apps/fcitx_tifinagh.pngis excluded by!**/*.pngicons/22x22/apps/org.fcitx.Fcitx5.fcitx_etruscan.pngis excluded by!**/*.pngicons/22x22/apps/org.fcitx.Fcitx5.fcitx_hebrew.pngis excluded by!**/*.pngicons/22x22/apps/org.fcitx.Fcitx5.fcitx_phoenician.pngis excluded by!**/*.pngicons/22x22/apps/org.fcitx.Fcitx5.fcitx_tifinagh.pngis excluded by!**/*.pngicons/24x24/apps/fcitx_etruscan.pngis excluded by!**/*.pngicons/24x24/apps/fcitx_hebrew.pngis excluded by!**/*.pngicons/24x24/apps/fcitx_phoenician.pngis excluded by!**/*.pngicons/24x24/apps/fcitx_tifinagh.pngis excluded by!**/*.pngicons/24x24/apps/org.fcitx.Fcitx5.fcitx_etruscan.pngis excluded by!**/*.pngicons/24x24/apps/org.fcitx.Fcitx5.fcitx_hebrew.pngis excluded by!**/*.pngicons/24x24/apps/org.fcitx.Fcitx5.fcitx_phoenician.pngis excluded by!**/*.pngicons/24x24/apps/org.fcitx.Fcitx5.fcitx_tifinagh.pngis excluded by!**/*.pngicons/32x32/apps/fcitx_etruscan.pngis excluded by!**/*.pngicons/32x32/apps/fcitx_hebrew.pngis excluded by!**/*.pngicons/32x32/apps/fcitx_phoenician.pngis excluded by!**/*.pngicons/32x32/apps/fcitx_tifinagh.pngis excluded by!**/*.pngicons/32x32/apps/org.fcitx.Fcitx5.fcitx_etruscan.pngis excluded by!**/*.pngicons/32x32/apps/org.fcitx.Fcitx5.fcitx_hebrew.pngis excluded by!**/*.pngicons/32x32/apps/org.fcitx.Fcitx5.fcitx_phoenician.pngis excluded by!**/*.pngicons/32x32/apps/org.fcitx.Fcitx5.fcitx_tifinagh.pngis excluded by!**/*.pngicons/48x48/apps/fcitx_etruscan.pngis excluded by!**/*.pngicons/48x48/apps/fcitx_hebrew.pngis excluded by!**/*.pngicons/48x48/apps/fcitx_phoenician.pngis excluded by!**/*.pngicons/48x48/apps/fcitx_tifinagh.pngis excluded by!**/*.pngicons/48x48/apps/org.fcitx.Fcitx5.fcitx_etruscan.pngis excluded by!**/*.pngicons/48x48/apps/org.fcitx.Fcitx5.fcitx_hebrew.pngis excluded by!**/*.pngicons/48x48/apps/org.fcitx.Fcitx5.fcitx_phoenician.pngis excluded by!**/*.pngicons/48x48/apps/org.fcitx.Fcitx5.fcitx_tifinagh.pngis excluded by!**/*.pngicons/64x64/apps/fcitx_etruscan.pngis excluded by!**/*.pngicons/64x64/apps/fcitx_hebrew.pngis excluded by!**/*.pngicons/64x64/apps/fcitx_phoenician.pngis excluded by!**/*.pngicons/64x64/apps/fcitx_tifinagh.pngis excluded by!**/*.pngicons/64x64/apps/org.fcitx.Fcitx5.fcitx_etruscan.pngis excluded by!**/*.pngicons/64x64/apps/org.fcitx.Fcitx5.fcitx_hebrew.pngis excluded by!**/*.pngicons/64x64/apps/org.fcitx.Fcitx5.fcitx_phoenician.pngis excluded by!**/*.pngicons/64x64/apps/org.fcitx.Fcitx5.fcitx_tifinagh.pngis excluded by!**/*.png
📒 Files selected for processing (9)
tables/CMakeLists.txttables/ett/etruscan.conf.intables/ett/etruscan.txttables/he/hebrew.conf.intables/he/hebrew.txttables/phn/phoenician.conf.intables/phn/phoenician.txttables/zgh/tifinagh.conf.intables/zgh/tifinagh.txt
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As a "fun" evening project, I've written these four new transliteration tables. I've tried to be conservative and follow the Unicode docs, especially for Hebrew and Tifinagh (which goes beyond Neo-Tifinagh and includes Tuareg letters).
There's probably an issue with the
LangCodesas I didn't know what to put, given that, except for hebrew, they don't have two-letter ISO-something-obsolete codes.I've been told to push this as well to
m17n, which I'll probably do once I get my head around Savannah and sending emails.Also, I'm a speaker of exactly none of these languages.
Summary by CodeRabbit