fix(notificationitem): show current input method name in SNI tooltip#1578
Merged
Conversation
Member
Title is shown here under, which seems to be better to be constant string. |
wyu71
force-pushed
the
fix/sni-tooltip-input-method-name
branch
from
6abae24 to
e64cdcb
Compare
The tooltip was hardcoded as "Input Method" and never updated on input method switch. Refactor title() to return the current input method entry name, and simplify tooltip() to reuse it. The existing notifyNewTooltip() now correctly emits the NewToolTip D-Bus signal when the input method changes.
…witch notifyNewTooltip() was comparing against title() which always returns the constant "Input Method", so NewToolTip signal was never emitted. Fix by comparing the actual tooltip content instead.
…witch notifyNewTooltip() was comparing against title() which always returns the constant "Input Method", so NewToolTip signal was never emitted. Fix by comparing the actual tooltip content instead.
wyu71
force-pushed
the
fix/sni-tooltip-input-method-name
branch
from
e64cdcb to
7c83dc8
Compare
Contributor
Author
|
@wengxt ，Thanks for the feedback. Updated: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
notifyNewTooltip()to compare actual tooltip content instead of the constanttitle()return valuenotifyNewTooltip()was comparing againsttitle()which always returns"Input Method", soNewToolTipD-Bus signal was never emitted and the tooltip never updated on input method switch