fix(editor): fix undo clearing out editor after initial load (#638) (#641)#7
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pulls upstream PR sibiraj-s/ngx-editor#641 into the fork ahead of upstream merging it.
Fixes upstream issue #638 — pressing Ctrl/Cmd+Z immediately after the editor loads no longer clears the initial content. The fix reworks
Editor.setContent()to callview.updateState()with a freshEditorStaterather than dispatching a transaction, so the initial content load is not recorded in the undo history.Summary
projects/ngx-editor/src/lib/Editor.ts—setContent()no longer creates an undoable transactionprojects/ngx-editor/src/lib/editor.component.spec.ts— two new specs cover the bug and the relatedsetContenthistory-reset behaviorTest plan
npm run test:libpasses locally against Angular v21 (33/33 tests, +2 new)