fix(editor): fix horizontal rule not allowing input on empty editor (#635) (#642)#8
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pulls upstream PR sibiraj-s/ngx-editor#642 into the fork ahead of upstream merging it.
Fixes upstream issue #635 — inserting a horizontal rule on an empty editor (and a few adjacent cursor-position cases) no longer leaves the editor in a state where the user can't type. The fix rewrites
HorizontalRule.insert()to split the parent block around the cursor, pad with an empty paragraph when needed so the cursor has a landing spot, and properly position the selection after the HR.Summary
projects/ngx-editor/src/lib/commands/HorizontalRule.ts— rewritteninsert()commandprojects/ngx-editor/src/lib/editor.spec.ts— new specs covering the regression and adjacent HR scenariosTest plan
npm run test:libpasses locally against Angular v21 (38/38, +5 new)