This repository was archived by the owner on Dec 20, 2020. It is now read-only.
Add support for toVersionString on result.os and result.ua#1
Open
shane-tomlinson wants to merge 1 commit intofedot:masterfrom
Open
Add support for toVersionString on result.os and result.ua#1shane-tomlinson wants to merge 1 commit intofedot:masterfrom
toVersionString on result.os and result.ua#1shane-tomlinson wants to merge 1 commit intofedot:masterfrom
Conversation
Owner
|
@shane-tomlinson, I'm pretty sure it's better to be added directly to the up-parser/uap-ref-impl as it's a reference implementation and at least some of the implementations (PHP, Go, Ruby) already implemented |
Author
|
Thanks @fedot, I'll open a version there. |
shane-tomlinson
force-pushed
the
add-toVersionString
branch
from
13fa830 to
81622f2
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ua-parser results had a
toVersionStringfunction onosandua. Add the missing support.