This repository was archived by the owner on Apr 17, 2023. It is now read-only.
🐛 RH-3754 Fix for sync queue messages#152
Merged
david-martin merged 1 commit intomasterfrom Jul 11, 2017
Merged
Conversation
wei-lee
approved these changes
Jul 11, 2017
david-martin
force-pushed
the
FH-3754-update-fh-sync-to-fix-messages-ttl
branch
3 times, most recently
from
c1a2a06 to
c758d67
Compare
aidenkeating
approved these changes
Jul 11, 2017
This updates the version fo the fh-sync module to include a fix for the ttl of queue messages. See feedhenry/fh-sync#22 for more info. The dependencies in package.json have also been updated to remove unused dependencies. These were discovered when looking at where the mongodb-queue module was being required. It was originally required in fh-mbaas-api, but was moved out with the sync implementation to the fh-sync module. The majority of the unused modules were from fh-sync, with a few extra ones discovered using this command: ``` dependency-check ./package.json --no-dev --unused ``` The npm-shrinkwrap.json file was regenerated as a result
david-martin
force-pushed
the
FH-3754-update-fh-sync-to-fix-messages-ttl
branch
from
c758d67 to
a8ee430
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This updates the version fo the fh-sync module to include a fix for the
ttl of queue messages.
See feedhenry/fh-sync#22 for more info.
The dependencies in package.json have also been updated to remove unused
dependencies.
These were discovered when looking at where the mongodb-queue module was
being required. It was originally required in fh-mbaas-api, but was
moved out with the sync implementation to the fh-sync module.
The majority of the unused modules were from fh-sync, with a few extra
ones discovered using this command:
The npm-shrinkwrap.json file was regenerated as a result