This repository was archived by the owner on Aug 10, 2020. It is now read-only.
Open
Conversation
adamjhc
suggested changes
Sep 10, 2019
| val menuLayoutParams = this.layoutParams as ViewGroup.MarginLayoutParams | ||
| menuLayoutParams.setMargins(0, marginTop, 0, 0) | ||
| this.layoutParams = menuLayoutParams | ||
| } No newline at end of file |
| } | ||
| this.makeStatusBarTransparent() | ||
|
|
||
|
|
| import android.view.WindowManager | ||
|
|
||
| fun Activity.makeStatusBarTransparent() { | ||
| if (Build.VERSION.SDK_INT >= Build.VERSION_CODES.LOLLIPOP) { |
Collaborator
There was a problem hiding this comment.
there's no compat way of doing this? I really dislike the look of this. Also why can't this just be a private function in the activity?
|
|
||
| fun Activity.makeStatusBarTransparent() { | ||
| if (Build.VERSION.SDK_INT >= Build.VERSION_CODES.LOLLIPOP) { | ||
| window.apply { |
Collaborator
There was a problem hiding this comment.
Suggested change
| window.apply { | |
| with(window) { |
It should be this unless window is what you're returning
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Works fine but doesn't seem to allow views to sit behind the status bar to change its colour. This current implantation though is a step in the right direction.