deps: swap @feralfile/source-resolver git URL for npm registry semver - #96
Merged
Conversation
Blocked on the resolver's first npm publish (feral-file/ff-source-resolver#11). npm 12 defaults allow-git=none, so the git-URL dependency breaks npm i -g @feralfile/cli for end users and npm ci for contributors. After the registry publish lands, regenerate package-lock.json with npm install and drop the README allow-git workaround note (done here). Note: ^1.0.0 is cut from current resolver main, two merges ahead of the old commit pin (playable artwork source resolution + hardening).
Contributor
Author
|
Blocked on the resolver's first npm publish: feral-file/ff-source-resolver#13 (assigned to @ngleanh). Once |
ngleanh
marked this pull request as ready for review
July 27, 2026 07:43
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Replaces the git-URL dependency on
@feralfile/source-resolverwith^1.0.0from the npm registry, and removes the README--allow-gitworkaround note that this makes obsolete.Why
npm 12's supply-chain defaults (
allow-git=none) refuse git-URL dependencies, which currently breaksnpm i -g @feralfile/clifor end users on npm 12 andnpm cifor contributors. Publishing the resolver properly fixes both without weakening npm's protections. Companion PR adding the resolver's publish pipeline: feral-file/ff-source-resolver#11.Draft until
@feralfile/source-resolver@1.0.0is published (bootstrap steps in that PR).package-lock.jsonis regenerated here withnpm install(CI stays red on lockfile mismatch until then).Note:
^1.0.0is cut from resolvermain, two merges ahead of the old commit pin — it picks up playable-artwork-source resolution and its hardening fix. ff-cli's resolver-path tests will exercise the delta once the lockfile lands.Bundled release binaries and the curl install path are unaffected either way (esbuild inlines the dependency); this changes only npm-based installs.