Merged
Conversation
There was a problem hiding this comment.
Pull Request Overview
Adds a new workflow for creating capability sets in FERRY, complete with verification steps and unit tests.
- Implements
NewCapabilitySetworkflow for group, unit, FQAN, and capability-set operations. - Enhances
FerryAPI.call_endpointandWorkflow.verify_outputfor better dry-run output and error handling. - Registers the new workflow and adds comprehensive tests for its methods.
Reviewed Changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| tests/test_NewCapabilitySet.py | Added unit tests for NewCapabilitySet.run and its helpers |
| ferry_cli/helpers/workflows.py | Improved verify_output error handling and removed sys.exit |
| ferry_cli/helpers/supported_workflows/init.py | Registered NewCapabilitySet in the supported workflows mapping |
| ferry_cli/helpers/supported_workflows/NewCapabilitySet.py | Implemented the new capability-set workflow |
| ferry_cli/helpers/api.py | Updated dry-run logging in call_endpoint to include parameters |
| ferry_cli/main.py | Modified output handling condition to check json_result |
Comments suppressed due to low confidence (2)
tests/test_NewCapabilitySet.py:83
- Typo in test function name: 'test_NewCapabiilitySet_run' has an extra 'i'. Rename to 'test_NewCapabilitySet_run' for consistency with the class name.
def test_NewCapabiilitySet_run(args, expected, capsys):
ferry_cli/helpers/workflows.py:43
- [nitpick] The error message 'Failed to verify output' is generic and used for multiple failure cases; consider providing more specific messages or include context about the failure reason.
print("Failed to verify output")
…oken subject to be FERRY UID
cathulhu
approved these changes
Jun 3, 2025
Collaborator
cathulhu
left a comment
There was a problem hiding this comment.
I see no issues and the replies to copilot comments make sense to me
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added workflow for creating a new capability set that mirrors https://github.com/DUNE/data-mgmt-ops/wiki/Dune-Physicsgroups-disk--how-to-create-a-new-physics-group
Also added tests for the workflow that ensure the correct APIs are getting called.
Closes #103