Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR adds a new command-line flag -s/--server that allows users to override the configured api.base_url value for quick testing of different FERRY instances.
- Adds server flag to auth parser with help text
- Modifies FerryCLI constructor to accept optional base_url parameter
- Updates main function to pass server flag value to FerryCLI constructor
- Adds comprehensive unit tests for both FerryCLI class and CLI functionality
- Refactors existing test to use parametrized approach
Reviewed Changes
Copilot reviewed 3 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| ferry_cli/helpers/auth.py | Adds the new -s/--server argument to the auth parser |
| ferry_cli/main.py | Updates FerryCLI constructor to accept base_url parameter and modifies main function to pass server flag |
| tests/test_main.py | Adds unit tests for server flag functionality and refactors existing test to use pytest parametrize |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
LTrestka
approved these changes
Sep 16, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #99
Adds a new flag,
-s/--server, that allows for users to override the configuredapi.base_urlvalue. This allows for quick testing of different FERRY instances.Also added unit tests for both the changed functionality in the
FerryCLIclass, and the overall CLI and new flag.All unit tests pass, as well as the following check: