Conversation
cathulhu
force-pushed
the
lydia_snake_case
branch
from
8c8865a to
49f4a89
Compare
shreyb
reviewed
Jan 23, 2025
shreyb
requested changes
Jan 23, 2025
Collaborator
shreyb
left a comment
shreyb
left a comment
There was a problem hiding this comment.
This looks good. I just had the one request for a change, and one general comment. The latter can be worked on in another issue.
shreyb
requested changes
Jan 23, 2025
- Converts snake case to lower camel case. - Handles edge case where proper endpoint is passed, but uses incorrect capitalization.
shreyb
reviewed
Apr 9, 2025
shreyb
reviewed
Apr 9, 2025
shreyb
reviewed
Apr 9, 2025
shreyb
reviewed
Apr 9, 2025
shreyb
reviewed
Apr 9, 2025
shreyb
reviewed
Apr 9, 2025
shreyb
reviewed
Apr 9, 2025
Collaborator
|
We revisited this in the 7/1/25 meeting, and decided that this was still worth completing. |
…oesnt end with trailing slash.
shreyb
requested changes
Sep 16, 2025
Collaborator
shreyb
left a comment
shreyb
left a comment
There was a problem hiding this comment.
This is certainly fine as is, but I think we could make a couple of more tweaks to really tighten up the code.
- renamed function to "normalize_endpoint" - removes args enumeration - called in endpoint/endpoint_params handler before safeguard.
shreyb
requested changes
Oct 10, 2025
Collaborator
|
LGTM |
shreyb
approved these changes
Oct 10, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is pull request for issue #94.