fix(maintain): reset learn markers in Step 7 — kill the permanent obs banner (v4.2.2)#86
Merged
Merged
Conversation
… banner (v4.2.2) observe.py touches .learn-pending every LEARN_THRESHOLD observations, but nothing cleared it after /cx-analyze retired in v4 — SessionStart's 'N+ new observations, run /cx-maintain' banner nagged forever, even right after a maintenance pass. Step 7 (commands/cx-maintain.md + bin/cx-maintain.sh, same embedded script) now snapshots the obs total into .last-learn-count (atomic tmp+rename), zeroes .obs-count and drops .learn-pending, so check_learn_pending() measures 'since last maintenance' again. test_cx_maintain_runner 9->10 (seeded markers reset e2e); suite also inventoried in the FEATURES.md tests table (missing since v4.0.0). Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problema
observe.pytoca.learn-pendingcada LEARN_THRESHOLD observaciones, pero desde que/cx-analyzese retiró en v4 nada lo limpiaba: el banner de SessionStart "N+ new observations, run /cx-maintain" insistía para siempre, incluso justo después de una pasada de mantenimiento (reproducido hoy: sesión arranca con "100+ new observations" y.learn-pendingpresente).Fix
Step 7 de
/cx-maintain(commands/cx-maintain.md+bin/cx-maintain.sh, mismo script embebido, paridad verificada):.last-learn-count(escritura atómica tmp+rename).obs-counta 0.learn-pendingCon eso
check_learn_pending()vuelve a medir "desde el último mantenimiento".Tests
test_cx_maintain_runner9→10: siembra markers + 3 observaciones en sandbox hermético y verifica el reset end-to-end tras el primer runbash -nen installer/runner/test🤖 Generated with Claude Code