Skip to content

test: expand MeshImporterExporter coverage#538

Merged
fernandotonon merged 1 commit into
masterfrom
test/mesh-importer-exporter-coverage
May 16, 2026
Merged

test: expand MeshImporterExporter coverage#538
fernandotonon merged 1 commit into
masterfrom
test/mesh-importer-exporter-coverage

Conversation

@fernandotonon
Copy link
Copy Markdown
Owner

Summary

  • Add 16 integration tests in MeshImporterExporter_test.cpp covering previously untested import/export branches.
  • Exercise PlayStation TMD/RSD and Psy-Q PLY import via MeshImporterExporter::importer, FBX/TMD/RSD/STL/GLB/versioned .mesh export, applyNormalMapsToEntity (tangents + RTSS), skeletal exportCurrentPose, XML skeleton export, and camera FOV edge cases.
  • Use inline minimal PS1/TMD/PLY fixtures (no new test assets); avoid tests that block on QMessageBox in headless CI.

Test plan

  • xvfb-run ./build_local/bin/UnitTests --gtest_filter on all new tests (16 passed)
  • CI unit-tests-linux on PR

Made with Cursor

Exercise PS1 TMD/RSD/Psy-Q PLY import paths, additional export formats
(FBX, TMD, RSD, STL, GLB, versioned Ogre meshes), normal-map RTSS
setup, camera edge cases, skeletal pose export, and dialog filters.

Co-authored-by: Cursor <cursoragent@cursor.com>
@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented May 16, 2026

Warning

Rate limit exceeded

@fernandotonon has exceeded the limit for the number of commits that can be reviewed per hour. Please wait 34 minutes and 31 seconds before requesting another review.

You’ve run out of usage credits. Purchase more in the billing tab.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 177c9190-e65a-4716-baba-8833d71018fb

📥 Commits

Reviewing files that changed from the base of the PR and between 6b00059 and 73c88e5.

📒 Files selected for processing (1)
  • src/MeshImporterExporter_test.cpp
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch test/mesh-importer-exporter-coverage

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@sonarqubecloud
Copy link
Copy Markdown

@fernandotonon fernandotonon merged commit d01cc8a into master May 16, 2026
36 of 37 checks passed
@fernandotonon fernandotonon deleted the test/mesh-importer-exporter-coverage branch May 16, 2026 22:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant