Skip to content

feat(morph): sub-slice A2 — Inspector Morph Targets subgroup #570

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
fernandotonon merged 3 commits into from
May 17, 2026
+138 −0
Merged

feat(morph): sub-slice A2 — Inspector Morph Targets subgroup #570

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
4d7146e
feat(morph): sub-slice A2 — Inspector Morph Targets subgroup
fernandotonon May 17, 2026
bcfa6ef
review(morph): address Codex finding on A2 — slider refresh
fernandotonon May 17, 2026
8f9f86c
review(morph): A2 — defensive `|| []` on morph targets binding
fernandotonon May 17, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
138 changes: 138 additions & 0 deletions qml/PropertiesPanel.qml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4306,6 +4306,144 @@ Rectangle {
}
}
}

// ---- Morph Targets / Blend Shapes (slice A2) ----
// Per-pose weight sliders, sourced from MorphAnimationManager.
// Lives at the bottom of the Animations section, outside the
// per-entity repeater above — morph data is read from the
// SelectionSet's first entity to keep the surface focused.
// Authoring (add/rename/delete) lands in A3.
Rectangle {
width: parent.width - 16
visible: morphCol.targetCount > 0
height: morphCol.implicitHeight + 12
color: PropertiesPanelController.headerColor
border.color: PropertiesPanelController.borderColor
border.width: 1
radius: 3

Column {
id: morphCol
anchors.fill: parent
anchors.margins: 6
spacing: 4

// Defensive `|| []` so an unexpected null return
// doesn't crash the binding — the manager currently
// always returns a QStringList, but contracts drift.
property var targets: MorphAnimationManager.morphTargetsForSelection() || []
property int targetCount: targets.length
property string filter: ""
// Bumped on `morphWeightChanged`; sliders bind their
// `value` to a function call gated on this counter so
// weight changes from any code path (Reset all,
// dope-sheet scrubs in later slices, MCP, etc.) flow
// back into the UI rather than going stale until the
// delegate is recreated.
property int weightTick: 0

Connections {
target: MorphAnimationManager
function onMorphTargetsChanged() {
morphCol.targets = MorphAnimationManager.morphTargetsForSelection() || []
morphCol.weightTick = morphCol.weightTick + 1
}
function onMorphWeightChanged(entity, name, weight) {
morphCol.weightTick = morphCol.weightTick + 1
}
Comment on lines +4345 to +4353
Copy link
Copy Markdown

@chatgpt-codex-connector chatgpt-codex-connector Bot May 17, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Refresh slider values when morph weights change

The new morph-target panel only re-fetches targets on morphTargetsChanged, but each slider value is derived from weightForSelection(modelData) and there is no handler for morphWeightChanged. As a result, when weights are changed outside direct drag interaction (for example clicking Reset all or any other code path that calls setWeightForSelection), the backend weight updates but the displayed slider/readout can stay stale until the delegates are recreated. This makes the inspector show incorrect state immediately after valid edits.

Useful? React with 👍 / 👎.

}

Row {
spacing: 4
width: parent.width
Text {
text: "Morph Targets (" + morphCol.targetCount + ")"
color: PropertiesPanelController.textColor
font.pixelSize: 11
font.bold: true
anchors.verticalCenter: parent.verticalCenter
}
Item { width: parent.width - 260; height: 1 }
// Reset all: walks every target and sets weight to 0.
Rectangle {
width: 60; height: 20; radius: 3
color: resetMa.containsMouse
? Qt.lighter(PropertiesPanelController.headerColor, 1.3)
: PropertiesPanelController.controlBgColor
border.color: PropertiesPanelController.borderColor
anchors.verticalCenter: parent.verticalCenter
Text {
anchors.centerIn: parent
text: "Reset all"
color: PropertiesPanelController.textColor
font.pixelSize: 9
}
MouseArea {
id: resetMa
anchors.fill: parent
hoverEnabled: true
cursorShape: Qt.PointingHandCursor
onClicked: {
for (var i = 0; i < morphCol.targets.length; ++i)
MorphAnimationManager.setWeightForSelection(morphCol.targets[i], 0)
}
}
}
}

// Filter / search — characters often have 50+ blend
// shapes, scanning a flat list is hopeless without
// a typeahead box.
TextField {
id: filterField
width: parent.width
placeholderText: "Filter targets…"
font.pixelSize: 10
onTextChanged: morphCol.filter = text
visible: morphCol.targetCount > 6
}

// One row per target. Hidden when filter doesn't match.
Repeater {
model: morphCol.targets
Row {
width: morphCol.width
spacing: 4
visible: morphCol.filter === ""
|| modelData.toLowerCase().indexOf(morphCol.filter.toLowerCase()) >= 0
height: visible ? 22 : 0

Text {
text: modelData
color: PropertiesPanelController.textColor
font.pixelSize: 10
width: 120
elide: Text.ElideRight
anchors.verticalCenter: parent.verticalCenter
}
Slider {
id: weightSlider
from: 0; to: 1; stepSize: 0.01
width: parent.width - 200
// Bind to `weightTick` so changes that
// bypass user drag (Reset all, MCP, future
// dope-sheet scrubs) refresh the readout.
value: (morphCol.weightTick,
MorphAnimationManager.weightForSelection(modelData))
anchors.verticalCenter: parent.verticalCenter
onMoved: MorphAnimationManager.setWeightForSelection(modelData, value)
}
Text {
text: weightSlider.value.toFixed(2)
color: PropertiesPanelController.textColor
font.pixelSize: 10
width: 36
anchors.verticalCenter: parent.verticalCenter
}
}
}
}
}
}
}

Expand Down
Loading