Skip to content

feat(ps1): Phase 0 scaffolding for runtime geometry extraction#574

Merged
fernandotonon merged 1 commit into
masterfrom
feat/ps1-runtime-extraction
May 17, 2026
Merged

feat(ps1): Phase 0 scaffolding for runtime geometry extraction#574
fernandotonon merged 1 commit into
masterfrom
feat/ps1-runtime-extraction

Conversation

@fernandotonon
Copy link
Copy Markdown
Owner

Summary

Closes #414. Contributes to #412 / #413.

Test plan

  • cmake -DENABLE_PS1_RIP=ON -DBUILD_TESTS=ON configures and builds UnitTests
  • UnitTests --gtest_filter="PS1RipManager*" passes (offscreen Qt)
  • CI green on Linux (coverage + build jobs)
  • Build with ENABLE_PS1_RIP=OFF unchanged (default)

Made with Cursor

…414)

Add ENABLE_PS1_RIP build flag, PS1RipManager/PS1RipWorker skeleton, design doc
for emulator core selection (#413), experimental menu entry, unit tests, and
CI coverage on Linux.

Co-authored-by: Cursor <cursoragent@cursor.com>
@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented May 17, 2026

Warning

Rate limit exceeded

@fernandotonon has exceeded the limit for the number of commits that can be reviewed per hour. Please wait 6 minutes and 45 seconds before requesting another review.

You’ve run out of usage credits. Purchase more in the billing tab.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: dbb5d996-4a27-4438-b86c-021625c58474

📥 Commits

Reviewing files that changed from the base of the PR and between 1b43207 and e60b21f.

📒 Files selected for processing (11)
  • .github/workflows/deploy.yml
  • CLAUDE.md
  • CMakeLists.txt
  • src/PS1/CMakeLists.txt
  • src/PS1/PS1_RIP_DESIGN.md
  • src/PS1/runtime/PS1RipManager.cpp
  • src/PS1/runtime/PS1RipManager.h
  • src/PS1/runtime/PS1RipManager_test.cpp
  • src/PS1/runtime/PS1RipWorker.cpp
  • src/PS1/runtime/PS1RipWorker.h
  • src/mainwindow.cpp
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch feat/ps1-runtime-extraction

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@sonarqubecloud
Copy link
Copy Markdown

@fernandotonon fernandotonon merged commit dbae64c into master May 17, 2026
20 checks passed
@fernandotonon fernandotonon deleted the feat/ps1-runtime-extraction branch May 17, 2026 14:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

PS1: Build option ENABLE_PS1_RIP + PS1RipManager skeleton

1 participant