-
Notifications
You must be signed in to change notification settings - Fork 0
feat(morph): sub-slice A5 — controller API for dope-sheet morph rows #576
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
+133
−0
Merged
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
8cd50f4
feat(morph): sub-slice A5 — dope sheet shows morph-weight tracks
fernandotonon 6589ebc
review(morph): A5 — filter morph keyTimes by pose target handle
fernandotonon 2abd71a
fix(morph): A5 — avoid overlap between bone ListView and morph band
fernandotonon 84f7b66
fix(morph): A5 — drop `onMorphWeightChanged` QML binding
fernandotonon d3cf05e
fix(morph): A5 — defer QML dope-sheet integration to a follow-up
fernandotonon File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Use the controller’s active entity before falling back to selection-set order.
allMorphRows()currently binds toentities.first(), which can mismatch the dope-sheet’s actively selected clip/entity under multi-selection and show morph rows from the wrong mesh.Suggested fix
QVariantList AnimationControlController::allMorphRows() const { QVariantList rows; - auto* sel = SelectionSet::getSingleton(); - if (!sel) return rows; - const auto entities = sel->getResolvedEntities(); - if (entities.isEmpty() || !entities.first()) return rows; - Ogre::Entity* entity = entities.first(); + Ogre::Entity* entity = m_selectedEntity; + if (!entity) { + auto* sel = SelectionSet::getSingleton(); + if (!sel) return rows; + const auto entities = sel->getResolvedEntities(); + if (entities.isEmpty() || !entities.first()) return rows; + entity = entities.first(); + } if (!entity) return rows;Also applies to: 902-950
🤖 Prompt for AI Agents