Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: b466e365fb
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| notify_on_count = 0 | ||
| for stock in stocks: | ||
| if stock.notify_enabled: | ||
| if stock.notify_days_before is not None: |
There was a problem hiding this comment.
notify_on_count is incremented only when notify_days_before is not None, but this codebase treats notify_days_before == None as “常に通知” (for example _should_notify returns True in src/UseCases/Line/CheckExpiredStockUseCase.py:11). As a result, stocks configured for always-notify are excluded from the “通知ONアイテム” dashboard metric, so the KPI is systematically undercounted (often near zero) even when notifications are effectively enabled.
Useful? React with 👍 / 👎.
- fix: stock.notify_enabled → notify_days_before is not None (Stock エンティティに存在しない属性参照)
- fix: url_for('stock_trash') → url_for('view_deleted_stock_list') (誤ったエンドポイント名)
- feat: アイテム登録後に通知設定をフォローアップメッセージで変更可能に
- 期限あり登録確認後に update_recent_notify コンテキストを保存
- update_recent_expiry 解決後も同様にチェーン
- アイテム名を補完して NLP に渡すことで「通知は3日前から」などを認識
- DummyIntentParserService に extra_responses 対応を追加
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
fezzlk
force-pushed
the
fix/nlp-notify-followup-and-500-errors
branch
from
b466e36 to
69951ef
Compare
1 participant
Summary
Bug fixes（本番で500エラー発生中）
stock.notify_enabled→stock.notify_days_before is not Noneに修正（Stockエンティティに存在しない属性を参照していた）url_for('views_blueprint.stock_trash')→url_for('views_blueprint.view_deleted_stock_list')に修正（誤ったエンドポイント名）Feature: 登録後の通知設定フォローアップ
update_recent_notifyコンテキストを保存update_recent_expiry（期限フォローアップ）解決後も同様にチェーンTest plan
/ホームページが 500 エラーなく表示される/stockアイテム一覧が 500 エラーなく表示される（削除済みボタンのリンクが正常）venv/bin/pytest src/UseCases/Line/tests/test_handle_intent_operation_use_case.py -vが全パス🤖 Generated with Claude Code