Skip to content

Fix changes to decorator settings not updating the WYSIWYG view#114

Merged
ffAudio merged 1 commit intoffAudio:mainfrom
isnotinvain:decorator-fix
Dec 7, 2025
Merged

Fix changes to decorator settings not updating the WYSIWYG view#114
ffAudio merged 1 commit intoffAudio:mainfrom
isnotinvain:decorator-fix

Conversation

@isnotinvain
Copy link
Contributor

Apologies if this is not the right way to fix this! I was having an issue where changing a combo box's caption size was updating the font size live but NOT moving the rest of the combo box out of the way like it's supposed to. A save + reload would render everything correctly, so after some investigating, I think this is the fix.

I think it has to do with this kind of change only effects the layout inside this item, and the rest of the flexbox system only cares about changes outside the item.

In any case, this does fix the problem. I did look pretty hard to see if I could put this more surgically somewhere relating to "the decorator has changed lets resize" but I think this might be the place?

I'm happy to take a different approach, but hopefully the fact that this does appear to fix the issue will give some insight into what the problem is at least.

Steps to reproduce:
Make a combo box, give it a caption in its decorator, set the caption to center-left, change the caption's size and notice the font change but the internal bounds of the caption vs the combo box do not update.

Apply this patch and it will update.

Thanks!

Copy link
Owner

@ffAudio ffAudio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great finding. I think it is benign to call this here in addition

@ffAudio ffAudio merged commit a9de8d8 into ffAudio:main Dec 7, 2025
4 checks passed
@isnotinvain
Copy link
Contributor Author

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants