Fix changes to decorator settings not updating the WYSIWYG view#114
Merged
ffAudio merged 1 commit intoffAudio:mainfrom Dec 7, 2025
Merged
Fix changes to decorator settings not updating the WYSIWYG view#114ffAudio merged 1 commit intoffAudio:mainfrom
ffAudio merged 1 commit intoffAudio:mainfrom
Conversation
ffAudio
approved these changes
Dec 7, 2025
Owner
ffAudio
left a comment
There was a problem hiding this comment.
Great finding. I think it is benign to call this here in addition
Contributor
Author
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Apologies if this is not the right way to fix this! I was having an issue where changing a combo box's caption size was updating the font size live but NOT moving the rest of the combo box out of the way like it's supposed to. A save + reload would render everything correctly, so after some investigating, I think this is the fix.
I think it has to do with this kind of change only effects the layout inside this item, and the rest of the flexbox system only cares about changes outside the item.
In any case, this does fix the problem. I did look pretty hard to see if I could put this more surgically somewhere relating to "the decorator has changed lets resize" but I think this might be the place?
I'm happy to take a different approach, but hopefully the fact that this does appear to fix the issue will give some insight into what the problem is at least.
Steps to reproduce:
Make a combo box, give it a caption in its decorator, set the caption to center-left, change the caption's size and notice the font change but the internal bounds of the caption vs the combo box do not update.
Apply this patch and it will update.
Thanks!