Skip to content

Make decorator captions respect LookAndFeel's font#115

Open
isnotinvain wants to merge 1 commit intoffAudio:mainfrom
isnotinvain:decorator-respect-laf-font
Open

Make decorator captions respect LookAndFeel's font#115
isnotinvain wants to merge 1 commit intoffAudio:mainfrom
isnotinvain:decorator-respect-laf-font

Conversation

@isnotinvain
Copy link
Contributor

No description provided.

g.setColour (captionColour);

g.setFont (captionSize * 0.8f);
g.setFont (lookAndFeel.getPopupMenuFont().withHeight (captionSize * 0.8f));
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we probably need to add getCaptionFont() to look and feel?

@ffAudio
Copy link
Owner

ffAudio commented Dec 13, 2025

Thanks for the suggestion.
I would definitely not use getPopupMenuFont(). I would probably not use the LookAndFeel at all. It makes sense for a system for developers, but not for a dynamic system.
The whole topic custom fonts is missing, not only for the caption, but in many places.
What I had in mind was to add fonts to the BinaryData and offer a property dropdown where it applies.
The caption could fetch this value directly, and bundled LookAndFeels could then be adapted to use the font from the XML.

@isnotinvain
Copy link
Contributor Author

Ya, better direct support for custom fonts would be great!
Currently the look and feel has lots of font related methods that do get respected as far as I can tell -- any reason to not have one for captions? Or you'd rather wait for a custom fonts refactor?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants